Skip to content

Commit

Permalink
Codeclimate doesn't support perf cops
Browse files Browse the repository at this point in the history
  • Loading branch information
benlangfeld committed Jan 1, 2024
1 parent 9937a86 commit ccd840f
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
4 changes: 0 additions & 4 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
require:
- rubocop-performance
- rubocop-rake

AllCops:
Expand Down Expand Up @@ -31,9 +30,6 @@ Metrics/ModuleLength:
Metrics/ParameterLists:
Max: 5

Performance/Casecmp:
Enabled: false

Style/CommandLiteral:
Exclude:
- 'test_database.rb'
Expand Down
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,4 @@ gem 'rspec-its', '~> 1.2'

gem 'codeclimate-test-reporter', '~> 1.0.3', group: :test, require: nil
gem 'rubocop', '~> 1.56.3', require: false
gem 'rubocop-performance'
gem 'rubocop-rake'
2 changes: 1 addition & 1 deletion lib/lhm/adapter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def rename_column(old_name, new_name)
# @param index_name [String]
def add_unique_index(columns, index_name = nil)
options = { unique: true }
options.merge!(name: index_name) if index_name # rubocop:disable Performance/RedundantMerge
options.merge!(name: index_name) if index_name

migration.add_index(table_name, columns, options)
end
Expand Down

0 comments on commit ccd840f

Please sign in to comment.