-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BSVR-82/FEAT] 시야 후기 등록 1차 UI 구현 #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고많았어~~~! xml 파일들 코드 컨벤션이랑 코드정렬 해주고!
<LinearLayout | ||
android:id="@+id/btn_take_photo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id 컨벤션 확인해주세요!
<DatePicker | ||
android:id="@+id/datePicker" | ||
android:layout_width="wrap_content" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요기도 id 컨벤션!
for (uri in newImageUris) { | ||
if (!selectedImageUris.contains(uri)) { | ||
selectedImageUris.add(uri) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이미 추가된 이미지 중복 방지하려고 넣은 것 같은데, 가독성 좋게 코틀린스럽게 변경해보면
selectedImageUris.addAll(newImageUris.filterNot { selectedImageUris.contains(it) })
updateImageViews()
이렇게 바꿔볼 수 있겠당 돌려보진 않아서 한 번 더블체크해보고!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
훨씬 좋네용 .. 감사합니다 !!
for ((index, uri) in selectedImageUris.withIndex()) { | ||
if (index < imageViews.size) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
selectedImageUris.forEachIndexed { index, uri ->
이렇게 바꿔볼 수도 있을 것 같아요 !
var onDateSelected: ((year: Int, month: Int, day: Int) -> Unit)? = null | ||
private var selectedYear: Int = Calendar.getInstance().get(Calendar.YEAR) | ||
private var selectedMonth: Int = Calendar.getInstance().get(Calendar.MONTH) | ||
private var selectedDay: Int = Calendar.getInstance().get(Calendar.DAY_OF_MONTH) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getInstance() 중복되는데, 하나로 만들고 그거 참조하는게 좋겠다!
val bundle = Bundle().apply { | ||
putStringArrayList(SELECTED_IMAGES, ArrayList(uriList)) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
val bundle = bundleOf(SELECTED_IMAGES to uriList)
이렇게 Pair 형태로 깔끔하게 바꿔 볼 수 있습니당
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생 많았어 민주!
@@ -0,0 +1,9 @@ | |||
<?xml version="1.0" encoding="utf-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
컨벤션이 아직 명확하지 않은거 같은데
``rect_gray50_fill_gray900_line_10```
이런식으로 하면 되려나? (10은 radius) stroke의 width까지 쓰려면 너무 복잡해지려나..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호 .. 그거까진 컨벤션을 안정했긴 한데 나중에 디자인 시스템 받구 다같이 정해보자 !
app/src/main/AndroidManifest.xml
Outdated
@@ -24,6 +28,11 @@ | |||
<category android:name="android.intent.category.LAUNCHER" /> | |||
</intent-filter> | |||
</activity> | |||
|
|||
<activity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
상관은 없지만 커밋할때는 다시 메인 액티비티로 하기로 했던거 같은데~~ (의미없는 트집)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 main은 그대로 두고 작업한 액티비티는 추가하는거 아니었나 ?!
android:background="@drawable/rect_white_fill_32"> | ||
|
||
<View | ||
android:id="@+id/iv_handler" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v_handler라고 해야하나? 애매하네
app:layout_constraintTop_toBottomOf="@id/tv_upload"> | ||
|
||
<LinearLayout | ||
android:id="@+id/btn_take_photo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
컨벤션 잡았다 요놈!
android:layout_width="wrap_content" | ||
android:layout_height="wrap_content" | ||
android:layout_marginStart="12dp" | ||
android:text="사진 촬영" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
미리 string.xml에 빼두는게 나려나? 지금 작업은 하는데 이것도 우리 string.xml에 어떻게 뺄지 컨벤션 간단히 컨벤션 정해야할거 같은데
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나중에 병합해서 한 사람이 작업하는게 좋을 것 같은뎅 다같이 이야기 해보장 !
import dagger.hilt.android.AndroidEntryPoint | ||
import java.util.Calendar | ||
|
||
@AndroidEntryPoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@androidentrypoint 어노테이션을 ImageUploadDialog 이미지 업로드 다이얼로그도 동일하게 적용시켜줘야 할거 같은데?!
💻주요 작업 내용
20240710_174517.mp4
🎞리뷰 요청 사항