[BSVR-111/FEAT] 시야 후기 등록 UI 디테일 및 디자인 추가 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minju1459
changed the title
Jokwanhee
reviewed
Jul 15, 2024
There was a problem hiding this comment.
UI 짜느라 고생했다 민주야~~
추가 궁금한거
- A안
// viewmodel
private val _test = MutableStateFlow("")
val test = _test.asLiveData()
// activity
viewModel.test.observe(this) {}
- B안
// viewmodel
private val _test = MutableStateFlow("")
val test = _test.asStateFlow()
// activity
viewModel.test.asLiveData().observe(this) {}
A안과 B안의 차이점이 뭘까..? 둘 다 똑같은 건가..? 성식이형한테 물어보쟈~ 혹시 민주는 둘의 차이점을 알고있니?
app/src/main/AndroidManifest.xml
Outdated
| @@ -55,11 +55,11 @@ | |||
| android:screenOrientation="portrait" /> | |||
|
|
|||
| <activity android:name="com.depromeet.presentation.seatReview.ReviewActivity" | |||
| android:exported="false" | |||
| android:exported="true" | |||
app/src/main/AndroidManifest.xml
Outdated
| android:screenOrientation="portrait"/> | ||
|
|
||
| <activity android:name="com.depromeet.presentation.seatReview.ReviewDoneActivity" | ||
| android:exported="false" | ||
| android:exported="true" | ||
| android:screenOrientation="portrait"/> |
BENDENG1
reviewed
Jul 15, 2024
| android:layout_height="match_parent"> | ||
|
|
||
| <ImageButton | ||
| android:id="@+id/btn_add_image" |
There was a problem hiding this comment.
우선 관희꺼랑 민주꺼 봤는데 추후에 xml 컨벤션도 맞춰서 한번 리팩토링 해야할거 같아! (물론 나도..)
Comment on lines
+57
to
+58
| ArrayAdapter(requireContext(), android.R.layout.simple_spinner_item, blockItems) | ||
| adapter.setDropDownViewResource(R.layout.custom_spinner_dropdown_item) |
나도 이거 진짜 궁금했는데, 난 A안으로 진행하긴 했어 ! 결론은 둘 다 돌아가긴 하는데 미리 livedata로 변환해주냐, 나중에 하냐 차이라 코드 스타일 차이아닐까 ?! 이따 물어보쟝 |
Jokwanhee
approved these changes
Jul 15, 2024
[BSVR-108/FEAT] 시야 찾기 UI 3차 구현
…nto feat/#23-seat-review-ui-final # Conflicts: # presentation/src/main/res/values/themes.xml
…nto feat/#23-seat-review-ui-final # Conflicts: # presentation/src/main/res/values/themes.xml # 무제
…nto feat/#23-seat-review-ui-final # Conflicts: # presentation/src/main/res/values/themes.xml
minju1459
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻주요 작업 내용
20240715_043938.mp4
🎞리뷰 요청 사항