fix: 없는 member_id로 차단 시도 시 예외 처리 (#398)

depromeet · Sep 7, 2024 · 307b505 · 307b505
1 parent 8c48045
commit 307b505
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 1 deletion.
diff --git a/module-domain/src/main/java/com/depromeet/member/port/in/usecase/MemberUseCase.java b/module-domain/src/main/java/com/depromeet/member/port/in/usecase/MemberUseCase.java
@@ -19,4 +19,6 @@ public interface MemberUseCase {
     Member createMemberBy(SocialMemberCommand command);
 
     MemberIdAndNickname findIdAndNicknameById(Long memberId);
+
+    boolean existsByMemberId(Long memberId);
 }
diff --git a/...domain/src/main/java/com/depromeet/member/port/out/persistence/MemberPersistencePort.java b/...domain/src/main/java/com/depromeet/member/port/out/persistence/MemberPersistencePort.java
@@ -34,4 +34,6 @@ public interface MemberPersistencePort {
     Optional<Member> updateProfileImageUrl(Long memberId, String profileImageUrl);
 
     Optional<MemberIdAndNickname> findIdAndNicknameById(Long memberId);
+
+    boolean existsByMemberId(Long memberId);
 }
diff --git a/module-domain/src/main/java/com/depromeet/member/service/MemberService.java b/module-domain/src/main/java/com/depromeet/member/service/MemberService.java
@@ -108,6 +108,11 @@ public MemberIdAndNickname findIdAndNicknameById(Long memberId) {
                 .orElseThrow(() -> new NotFoundException(MemberErrorType.NOT_FOUND));
     }
 
+    @Override
+    public boolean existsByMemberId(Long memberId) {
+        return memberPersistencePort.existsByMemberId(memberId);
+    }
+
     @Override
     public Member update(UpdateMemberCommand command) {
         if (command.nickname() != null && command.nickname().isBlank()) {

diff --git a/module-domain/src/test/java/com/depromeet/mock/member/FakeMemberRepository.java b/module-domain/src/test/java/com/depromeet/mock/member/FakeMemberRepository.java
@@ -130,4 +130,9 @@ public Optional<MemberIdAndNickname> findIdAndNicknameById(Long memberId) {
         return findById(memberId)
                 .map(item -> new MemberIdAndNickname(item.getId(), item.getNickname()));
     }
+
+    @Override
+    public boolean existsByMemberId(Long memberId) {
+        return false;
+    }
 }
diff --git a/.../persistence-database/src/main/java/com/depromeet/member/repository/MemberRepository.java b/.../persistence-database/src/main/java/com/depromeet/member/repository/MemberRepository.java
@@ -132,6 +132,16 @@ public Optional<MemberIdAndNickname> findIdAndNicknameById(Long memberId) {
                 new MemberIdAndNickname(result.get(0, Long.class), result.get(1, String.class)));
     }
 
+    @Override
+    public boolean existsByMemberId(Long memberId) {
+        return !queryFactory
+                .select(member.id)
+                .from(member)
+                .where(member.id.eq(memberId))
+                .fetch()
+                .isEmpty();
+    }
+
     @Override
     public Optional<Member> updateGender(Long memberId, MemberGender gender) {
         return memberJpaRepository

diff --git a/module-presentation/src/main/java/com/depromeet/blacklist/facade/BlacklistFacade.java b/module-presentation/src/main/java/com/depromeet/blacklist/facade/BlacklistFacade.java
@@ -7,7 +7,9 @@
 import com.depromeet.blacklist.port.in.usecase.BlacklistQueryUseCase;
 import com.depromeet.exception.BadRequestException;
 import com.depromeet.friend.port.in.command.DeleteFollowCommand;
+import com.depromeet.member.port.in.usecase.MemberUseCase;
 import com.depromeet.type.blacklist.BlacklistErrorType;
+import com.depromeet.type.member.MemberErrorType;
 import lombok.RequiredArgsConstructor;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.context.ApplicationEventPublisher;
@@ -19,6 +21,7 @@
 @RequiredArgsConstructor
 public class BlacklistFacade {
     private final ApplicationEventPublisher eventPublisher;
+    private final MemberUseCase memberUseCase;
     private final BlacklistQueryUseCase blacklistQueryUseCase;
     private final BlacklistCommandUseCase blacklistCommandUseCase;
 
@@ -30,7 +33,9 @@ public void blackMember(Long memberId, BlackMemberRequest request) {
         if (memberId.equals(blackMemberId)) {
             throw new BadRequestException(BlacklistErrorType.CANNOT_BLACK_MYSELF);
         }
-
+        if (!memberUseCase.existsByMemberId(blackMemberId)) {
+            throw new BadRequestException(MemberErrorType.NOT_FOUND);
+        }
         boolean isAlreadyBlacked = blacklistQueryUseCase.checkBlackMember(memberId, blackMemberId);
         if (isAlreadyBlacked) {
             throw new BadRequestException(BlacklistErrorType.ALREADY_BLACKED);