Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 알림 일괄 읽음 처리 #423

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

its-sky
Copy link
Member

@its-sky its-sky commented Sep 13, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 알림을 클릭 시 hasRead=true로 처리하는 것이 아니라 알림 창에 들어갔을 때 미확인 알림을 모두 hasRead=true로 처리하도록 변경하였습니다.
  • Dockerfile 내부에 gradle build를 포함하였습니다. 추후 CI/CD 파이프라인 설계 변경 시 빌드 스크립트 수정이 필요하지 않도록 하고, 멀티 스테이징 이미지 빌드를 통해 이미지 크기 최적화를 수행하였습니다. (620MB -> 366MB)
  • Production 서버의 SQL문 출력을 제거하였습니다. (application-prod.yml 참고)

📝 참고사항

image

Copy link

github-actions bot commented Sep 13, 2024

Test Results

64 tests   64 ✅  2s ⏱️
17 suites   0 💤
17 files     0 ❌

Results for commit 405a9a8.

♻️ This comment has been updated with latest results.

Copy link
Member

@ywonchae1 ywonchae1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

scripts/Dockerfile-prod Outdated Show resolved Hide resolved
@its-sky its-sky merged commit 51d57db into develop Sep 13, 2024
2 checks passed
@its-sky its-sky deleted the refactor/422-read-notification branch September 13, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ 알림 조회 시 읽기 처리
2 participants