Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: 수영 시간 계산 시 초 단위로 계산 #442

Merged
merged 1 commit into from
Oct 10, 2024
Merged

hotfix: 수영 시간 계산 시 초 단위로 계산 #442

merged 1 commit into from
Oct 10, 2024

Conversation

ywonchae1
Copy link
Member

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 수영 시간을 계산할 때 시간끼리, 분끼리 차를 반환하고 있었습니다.
  • 그러다보니 1시 30분 - 2시 20분은 1시(2-1) 50분(140 - 90) 으로 결과가 나오고 있었습니다.

Solution

  • 먼저 Duration을 통해 시간 사이 간격을 구하고 0시 0분에서 초를 더하는 방식으로 해결하였습니다.

@ywonchae1 ywonchae1 self-assigned this Oct 10, 2024
@ywonchae1 ywonchae1 linked an issue Oct 10, 2024 that may be closed by this pull request
🐛 수영 시간 계산 공식 수정 #441
Closed
@github-actions GitHub Actions
Copy link

Test Results

64 tests   64 ✅  2s ⏱️
17 suites   0 💤
17 files     0 ❌

Results for commit f7a7c8d.

its-sky
its-sky approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@its-sky its-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

@ywonchae1 ywonchae1 merged commit 98cdae1 into develop Oct 10, 2024
3 checks passed
@ywonchae1 ywonchae1 deleted the hotfix/441-duration branch October 10, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@its-sky its-sky its-sky approved these changes

@penrose15 penrose15 Awaiting requested review from penrose15

Assignees

@ywonchae1 ywonchae1

Labels
bug Something isn't working 🚨🚨emergency🚨🚨 fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 수영 시간 계산 공식 수정
2 participants
@ywonchae1 @its-sky