-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript conversion #621
Merged
Merged
Changes from 164 commits
Commits
Show all changes
174 commits
Select commit
Hold shift + click to select a range
c01794a
Add setup for building with typescript
craigbeck 1237529
Use internal refs to lib
craigbeck 81a9fe4
Move files from lib/ to src/
craigbeck 18b187b
Build from src/ to dist/ and adjust test require paths to test built …
craigbeck c8b1cc4
Fix eslint paths
craigbeck d52e56c
Rename util.js
craigbeck f9f27b2
Use export
craigbeck 24f3fc3
Rename dependencyOptions.js
craigbeck 25ba3cf
Convert dependencyOptions to typescript
craigbeck bdcf8c7
Rename contexts.js
craigbeck dbc5f10
Convert context to typescript
craigbeck a57b9f8
Convert operatorFns to typescript
craigbeck 774a441
Rename expressions.js
craigbeck dbd2f96
Convert expressions to typescript
craigbeck 9d99006
Rename templates.js
craigbeck e7e6067
Use import for serialize-object
craigbeck e9ee6ad
No console log in test
craigbeck 5ff3626
Add dom to tsconfig lib
craigbeck 3108a6e
Fix misnamed functions
craigbeck ecdb38c
Convert tempaltes to typescript (19 tests fail)
craigbeck 6b27008
Fix misnamed method
craigbeck 2eb792f
Add initial typescript linting setup
craigbeck c891717
Automated eslint --fix
craigbeck c90c713
Lint fixes
craigbeck d83d26d
Change to @ts-expect-error or resolve @ts-error
craigbeck 12952f1
Remove node 14, add node 20 to test matrix
craigbeck 8381520
Fix test for parsing error to pass on node v20 (v20 changed error mes…
craigbeck 8470cb4
Adding types to context and templates
craigbeck d8dc21c
More typing; 2 DynamicElement test failures
craigbeck 6e4e9b3
Fix DynamicElement tests by moving shared Element behavior to BaseEle…
ericyhwang 4d6321a
Sort imports
craigbeck c241d81
Type render functions
craigbeck 7687caf
Expression method typings
craigbeck cdeaaa0
Skip unimplemented test
craigbeck 8976ac1
Type Segments
craigbeck 2982a97
ExpressionMeta type literals
craigbeck b8d8997
Remove extraneous return types
craigbeck 6f3be73
Use method syntax
craigbeck 965fc07
Placeholder type for value
craigbeck 91e60a1
Placeholder type for value
craigbeck c0ef475
Return type Segments
craigbeck 93c3907
Placeholder for BlockType
craigbeck c4518bb
Type dependency options; more tempalte class method typings
craigbeck 77434e5
Rename createPathExpression.js
craigbeck 79ac1d0
Lint fix expressions.ts
craigbeck a6eb717
Typescript fixes for createPathExpression
craigbeck da43484
Eslint: ignore unused args prefixed with underscore
craigbeck 8d89588
Rename tempaltes/index.js
craigbeck 9b65766
Convert index to typescript
craigbeck b0956ab
Convert createPathExpression to typescript
craigbeck cbafddd
Raname parsing/markup.js
craigbeck 024ae75
Remove console.log
craigbeck 76d1371
Use type for checking type guards
craigbeck a893153
Convert parsing/markup to typescript
craigbeck 5e8cfb6
Rename parsing/index.js
craigbeck 43b0cfc
Add types for much of templates.ts
ericyhwang c26c943
Remove extraneous isSpreadElement check
craigbeck 846720d
Convert parsing/index to typescript
craigbeck aa78ae3
Merge branch 'ts-conversion-1' of github.com:derbyjs/derby into ts-co…
craigbeck b97278c
Ignore error w DynamicAttribute until generic added to resolve
craigbeck dfbcda6
Formatted
craigbeck 96a93b2
Add eslint prettier, and import sort; Demote usage of any to warning …
craigbeck d09d22f
Sort imports
craigbeck a3b0ab8
Use Obejct.prototype.hasOwnProperty
craigbeck 6108f39
Remove unused functions
craigbeck 54cbbe4
Disable eslint no-unused-vars to prevent duplicate errors with typesc…
craigbeck a569d9c
Remove unused dependency through
craigbeck 2d53114
Resolve unused-var linting errors
craigbeck 83bd54c
Switch typescript to tilde versioning, since TS major releases increm…
ericyhwang 9be00ad
Rename Controller.js
craigbeck e7483ca
Convert Controller to typescript
craigbeck f201e68
Rename App.js
craigbeck 7cf9159
Rename AppForServer.js
craigbeck b9418df
Convert App, AppFoprServer, Controller to typescript
craigbeck 9dd6407
Use export syntax
craigbeck 1e7c7b2
Fix semicolons
craigbeck 583512d
Lint fixes
craigbeck a2612e8
Rename Derby.js
craigbeck d825091
Convert Derby.js to typescript
craigbeck 6802dbd
Fix App import in DerbyStandalone
craigbeck a16e370
Merge branch 'ts-conversion-1' of github.com:derbyjs/derby into ts-co…
craigbeck 0d6d68e
Type parsing/index methods
craigbeck d4fa7cf
More types for parsing
craigbeck 2ce439d
Rename Page.js
craigbeck bfe897d
Make DependencyOptions options... optional
craigbeck f7d8608
Rename PageForServer.js
craigbeck eaa3253
Convert App and AppForServer to typescript
craigbeck 18c5b43
Add markerNode property to Controller as used by Hook
craigbeck cd67337
Convert Page and PageFroServer to typescript
craigbeck 5033e46
Convert components to typescript
craigbeck 08eba28
Make Context generic and eslint-ignore this-alias
craigbeck 32b734e
Handle diffrences between Page/Component in expressions
craigbeck 2a127a5
Dont alias DependencyOptions
craigbeck 22c81b9
Create local Hook class for markerHooks
craigbeck 496cc41
Conversion + typing for App, Controller, Page, components
craigbeck 7329903
No passing this to super in PageBase (handled by this.page assignment)
craigbeck b9f561b
Add ESTree types
craigbeck 998ebbd
Use Model type rather than ModelData (incorrect type)
craigbeck 25add99
Remove unused guard function
craigbeck e997c25
Syntax fix
craigbeck 79903c5
Remove unnecessary regex escape
craigbeck e0afaff
Disable prefer-spread for function apply
craigbeck 8a24820
Supress error until correct types for bindings can be sorted out
craigbeck 0889e37
Add return types
craigbeck b016cd6
3.0.0-beta.1
craigbeck 10ab08b
Fix DerbyForDerver, and Racer require
craigbeck 2fa7887
Rename DerbyForServer.js
craigbeck 5bd5169
Use DerbyBase class as base for Derby and DerbyForServer
craigbeck b44037e
Rename DerbyStandalone.js
craigbeck bd2b226
Convert DerbyStandalone to typescript
craigbeck 9e469d4
Handle DerbyForServer non-default export
craigbeck 0ae26b2
Lift use and serverUse to base class
craigbeck d1402e1
Call _init in AppForServer
craigbeck 8d81f7e
Move methods to base class
craigbeck c369c86
Initialize _pendingComponentMap in base class
craigbeck 02544aa
Lift Component to base class
craigbeck 382c97f
Use package exports to map derby/parsing
craigbeck a3e4c0b
Map exports for templates and AppForServer
craigbeck fd8076a
Map App export and lib/App (for derby-webpack)
craigbeck 7e8a4e6
Lift onRoute to AppBase
craigbeck 543442a
Ensure app Page class is being used appropriately
craigbeck 796c3d4
Split derby server + client requries
craigbeck 42698f8
Use arrow-function
craigbeck 6ae6209
Convert callbacks to arrow-functions
craigbeck fb8bb60
Extract finishInit to local arrow-function
craigbeck 17ee8bb
Remove abstract from MarkupHook class
craigbeck 44a0092
Revert "Remove abstract from MarkupHook class"
craigbeck 54db640
Use named import over require
craigbeck 840f68c
Ensure MarkupHooks have valid module attribute
craigbeck 309cb4a
3.0.0-beta.2
craigbeck a1e7b21
Add types
craigbeck f6d4da8
Type PageForServer
craigbeck 56a4c4d
Additional types Apps and Pages; proctected methods
craigbeck af74798
Include all dist in published package
craigbeck a812eed
3.0.0-beta.3
craigbeck 3f60401
Merge branch 'master' of github.com:derbyjs/derby into ts-conversion-1
craigbeck 9eec95c
Make args optional on parseViews
craigbeck c537804
Remove generic from Controller
craigbeck 211bb7b
Code review cleanups
ericyhwang 67d60fb
Include test-utils in published output
craigbeck 2150df6
Merge branch 'ts-conversion-1' of github.com:derbyjs/derby into ts-co…
craigbeck 3136502
Add test-utils/index.js to exports
craigbeck 08bd44a
3.0.0-beta.4
craigbeck 1ede576
Remove exports of ./lib/* as majro version and exports changes requir…
craigbeck bff71ec
3.0.0-beta.5
craigbeck c141692
Rename src/index.js
craigbeck 6bff0de
Remove DerbyForServer in favor of server
craigbeck 4b5434f
Fix issue of App being untyped in consuming code due to dynamic export
craigbeck 15fecf1
Export run function
craigbeck bddf1b7
Add generic to Controller for model data
craigbeck 4ef80f6
Extract routes setup
craigbeck e2928f9
BREAKING: change arg order for render so method signatures can be ali…
craigbeck 8f5eb5a
Use Model generic
craigbeck 069d240
Create constructor type for singletone components that do not use con…
craigbeck 321cab8
Add no-op render to satisfy need to have method on PageBase
craigbeck 0ad4d1f
Export route types and add method types for Page
craigbeck f26df28
Rename Dom.js
craigbeck 8e3414e
Convert Dom to typescript
craigbeck bf7e91f
Export type PageBase, PageParams
craigbeck fefb0e4
Addition typing for view prop and type debounce fns
craigbeck c7a9902
Refine Dom target types
craigbeck ec4f389
Delay as optional arg
craigbeck 5342135
Additional typing and method signatures for Dom event listener methods
craigbeck 620dcee
Use RootModel and ChildModel over Model
craigbeck aa592a4
Use const require for Racer due to not actually having types
craigbeck efbe310
3.0.0-beta.6
craigbeck f3bed84
Re-type Dom listeners
craigbeck c22c099
3.0.0-beta.7
craigbeck 2299fc5
Re-export util
craigbeck 7414202
3.0.0-beta.8
craigbeck 1b4d936
Revert back to use Model over ChildModel types
craigbeck 8dfdc9b
Require racer
craigbeck f02ec7d
Revert to exportig derby instance from index; not publishing types
craigbeck 1d3e42a
3.0.0-beta.9
craigbeck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,4 @@ | |
*.swp | ||
node_modules | ||
.vscode | ||
dist/ |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
turned
off
soa as to not duplicate/conflict with typescript rule that does same