Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DesiTest and other commands #178

Merged
merged 6 commits into from
Jan 30, 2025
Merged

Remove DesiTest and other commands #178

merged 6 commits into from
Jan 30, 2025

Conversation

weaverba137
Copy link
Member

This PR removes DesiTest as requested in desihub/desiutil#215.

@weaverba137 weaverba137 requested a review from sbailey January 15, 2025 18:29
@weaverba137 weaverba137 self-assigned this Jan 15, 2025
@coveralls
Copy link

coveralls commented Jan 15, 2025 •
edited
Loading

Coverage Status

coverage: 50.113%. remained the same
when pulling 843f4b3 on remove-desi-test
into f62def5 on main.

@weaverba137 weaverba137 mentioned this pull request Jan 30, 2025
Merged
sbailey
sbailey approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@sbailey sbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. For the record, removing DesiTest means that "python setup.py test" no longer works, but I confirmed that bare "pytest" works without it picking up extraneous non-tests.

@sbailey sbailey merged commit 687ba87 into main Jan 30, 2025
12 checks passed
@sbailey sbailey deleted the remove-desi-test branch January 30, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbailey sbailey sbailey approved these changes

Assignees

@weaverba137 weaverba137

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weaverba137 @coveralls @sbailey