Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to match RA/Dec positions to Main Survey targets #820

Merged
merged 5 commits into from
May 6, 2024

Conversation

geordie666
Copy link
Contributor

This PR adds a function to match RA/Dec positions to Main Survey targets (desitarget.secondary.match_to_main_survey()).

The purpose of this function is to provide a straightforward way for proposers of spare-fiber programs to check how many of their likely targets already match main-survey targets.

@geordie666
Copy link
Contributor Author

This PR adds a standalone function with no other dependencies so should be uncontroversial. I'll merge it soon in preparation for an impending call for new spare-fiber targets.

@moustakas
Copy link
Member

Nice. Quick comment to consider: Would it be useful to add the targeting columns (DESI_TARGET, BGS_TARGET, etc.) as well as TARGETID (for matches) so the user can understand why an object was targeted in the main survey?

@geordie666
Copy link
Contributor Author

Yep, good idea. I'll add those.

@geordie666
Copy link
Contributor Author

I've added the TARGETIDs to the output file. I didn't add the other columns @moustakas suggested: The issue is that all of the _TARGET columns can be different for each of the dark, bright, secondary/dark, secondary/bright combinations, so the extra information in the file quickly proliferates.

Users interested in provenance should be able to use the TARGETIDs to look up extra information.

@geordie666 geordie666 merged commit 9e3bcd1 into main May 6, 2024
11 of 12 checks passed
@geordie666 geordie666 deleted the ADM-spare-fibers-match branch May 6, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants