Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of extractions at different wavelengths per fiber #85

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

segasai
Copy link
Contributor

@segasai segasai commented Jan 9, 2025

This is an initial implementation.
First get_spots() is updated to support 2d wavelength arrays. The tests were added to check we get the same results with 2d array as with 1d array.
The next step is to figure out what's the best way to update the extract_frame() interface.

@segasai
Copy link
Contributor Author

segasai commented Jan 9, 2025

After creating a test implementation of the extract_frame() that supports 2d wavelength array, i realized that since extract_frame returns a desispec.Frame (which only has a 1d wavelength array), so it wouldn't quite make sense to just allow 2d wavelength input for extract_frame.

The two alternatives for extract_frame() is

  1. Allow 1d wavelength_array input, and optional velocity offset array per fiber
  2. Allow 2d wavelength array, and additional 1d wavelength array (that will be in the in the returned desispec.Frame), i.e. this is for the case where 2d wavelength array is the telescope frame wavelengths, and the 1d frame is the barycentric frame grid on which the result will be.

I think 2 is cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant