Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement accurate and flexible fiberloss calculations #52

Merged
merged 49 commits into from
Jan 17, 2017
Merged

Conversation

dkirkby
Copy link
Member

@dkirkby dkirkby commented Oct 29, 2016

This is not ready to merge yet but is getting close. Here is the final checklist:

  • Add support for point-like sources.
  • Anti-alias fiber aperture.
  • Read and use file of optional achromatic centroid offsets.
  • Add option to save pre-tabulated fiberloss for later use w/o galsim.
  • Review documentation of new features.
  • Compare with fiberloss files in desimodel.
  • Optimize numerical parameters num_wlen, num_pixels.
  • Add some unit tests of new features.

The goal of this PR is to obtain correct results at the required level of realism. Optimizations for efficient calculation of a large number (~5K) of sources distributed over the focal plane in a single exposure are not considered here.

@dkirkby dkirkby self-assigned this Nov 3, 2016
@dkirkby
Copy link
Member Author

dkirkby commented Jan 10, 2017

The new fiberloss module can now save the results of an on-the-fly galsim calculation to a file with the same format as used in desimodel, so we have a mechanism to update the files desimodel/data/throughput/fiberloss-xxx.dat to be more realistic, if we want to.

@dkirkby
Copy link
Member Author

dkirkby commented Jan 17, 2017

I am going to close this now (and defer the last 3 items in the checklist) in order to have a stable base for working on #6.

@dkirkby dkirkby merged commit d528b49 into master Jan 17, 2017
@dkirkby dkirkby deleted the Fiberloss branch January 17, 2017 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant