Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swap latest main and preview clusters to RDS #10164

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented Oct 31, 2024

Ticket

Description

We removed --deployment-type=simple because Aurora V1 is going away, so these deployments need to move to RDS. My idea is to rename these deployments so CFN will be happy then manually run the migration guide to restore DB state on the new clusters. Alternatively, we can just lose the state but that kinda sucks.

Test Plan

N / A

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.26%. Comparing base (8c95047) to head (7839ac4).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10164      +/-   ##
==========================================
- Coverage   54.27%   54.26%   -0.01%     
==========================================
  Files        1259     1259              
  Lines      157285   157285              
  Branches     3644     3642       -2     
==========================================
- Hits        85359    85346      -13     
- Misses      71793    71806      +13     
  Partials      133      133              
Flag Coverage Δ
backend 45.89% <ø> (-0.03%) ⬇️
harness 71.15% <ø> (ø)
web 54.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 7839ac4
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6722d4a140ab6500086d27b5
😎 Deploy Preview https://deploy-preview-10164--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stoksc stoksc force-pushed the swap-latest-main-preview-to-rds branch from 9f28475 to 7839ac4 Compare October 31, 2024 00:51
@stoksc stoksc marked this pull request as ready for review October 31, 2024 00:54
@stoksc stoksc requested a review from a team as a code owner October 31, 2024 00:54
@stoksc stoksc requested a review from dannysauer October 31, 2024 00:54
@stoksc stoksc merged commit 227eab8 into main Oct 31, 2024
82 of 94 checks passed
@stoksc stoksc deleted the swap-latest-main-preview-to-rds branch October 31, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants