Skip to content

Commit

Permalink
fix(eval/latencies): generate metadata for warmup_rate
Browse files Browse the repository at this point in the history
This removes the requirement where we had to put `warmup_rate` value in
the list of rates that we test. This speeds up the test and also allows
us to test only one variant, when there is only one rate value.
  • Loading branch information
qlonik committed May 3, 2024
1 parent ed324c0 commit 2b4f466
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions evaluation/scripts/collect-latencies.mts
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ const bookinfo_variants = new Set([
] as const)
/**
* Which variants to test during this run.
* Note, that there has to be more than one variant here, since with one
* variant, there is some weird behavior where each second attack fails for
* most of the requests.
* Note, that there has to be more than one variant here if we are testing more
* than one rate value. That is because with one variant, there is some weird
* behavior where each second attack fails for most of the requests.
*/
const test_only = new Set<VARIANT>([
"plain",
Expand Down Expand Up @@ -86,7 +86,7 @@ await (async function main() {
)
const metadata_map = new Map<RATE, Map<VARIANT, METADATA>>()
for (const rate of rates) {
for (const rate of new Set<RATE>([warmup_rate, ...rates])) {
const map = new Map<VARIANT, METADATA>()
for (const variant of test_only) {
Expand Down

0 comments on commit 2b4f466

Please sign in to comment.