Skip to content

Commit

Permalink
feat: panic on filter constructor errors
Browse files Browse the repository at this point in the history
Co-authored-by: Nikita Volodin <[email protected]>
Co-authored-by: Miti Mazmudar <[email protected]>
  • Loading branch information
dettanym and qlonik committed Feb 29, 2024
1 parent 579e0bb commit c646e07
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
6 changes: 5 additions & 1 deletion privacy-profile-composer/pkg/envoyfilter/config_factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ func ConfigFactory(c interface{}) api.StreamFilterFactory {
}

return func(callbacks api.FilterCallbackHandler) api.StreamFilter {
return NewFilter(callbacks, conf)
filter, err := NewFilter(callbacks, conf)
if err != nil {
panic(err)
}
return filter
}
}
10 changes: 5 additions & 5 deletions privacy-profile-composer/pkg/envoyfilter/filter.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ import (
"privacy-profile-composer/pkg/envoyfilter/internal/common"
)

func NewFilter(callbacks api.FilterCallbackHandler, config *config) api.StreamFilter {
func NewFilter(callbacks api.FilterCallbackHandler, config *config) (api.StreamFilter, error) {
sidecarDirection, err := common.GetDirection(callbacks)
if err != nil {
log.Fatal(err)
return nil, err
}

tracer, err := common.NewZipkinTracer(config.zipkinUrl)
if err != nil {
log.Fatalf("unable to create tracer: %+v\n", err)
return nil, fmt.Errorf("unable to create tracer: %+v\n", err)
}

opaObj, err := sdk.New(context.Background(), sdk.Options{
Expand All @@ -33,7 +33,7 @@ func NewFilter(callbacks api.FilterCallbackHandler, config *config) api.StreamFi
})

if err != nil {
log.Fatalf("could not initialize an OPA object --- "+
return nil, fmt.Errorf("could not initialize an OPA object --- "+
"this means that the data plane cannot evaluate the target privacy policy ----- %+v\n", err)
}

Expand All @@ -43,7 +43,7 @@ func NewFilter(callbacks api.FilterCallbackHandler, config *config) api.StreamFi
tracer: tracer,
sidecarDirection: sidecarDirection,
opa: opaObj,
}
}, nil
}

type Filter struct {
Expand Down

0 comments on commit c646e07

Please sign in to comment.