Opa rego changes #100
Merged
Opa rego changes #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qlonik
force-pushed
the
opa-rego-changes
branch
from
155492d to
b17ac25
Compare
It seems that while this is not a strict requirement, lots of OPA documentation suggests to put bundles under `/bundles` path.
This will match the request URL that is done in OPA sdk within golang filter implementation.
Turns out OPA does not like when there are few defaults for the same variable across rego files in the package.
Co-authored-by: Miti Mazmudar <[email protected]>
A lot of things that are commented out and not needed are removed.
This file exists on opa website under golang SDK tutorial.
qlonik
force-pushed
the
opa-rego-changes
branch
from
b17ac25 to
ca8d0a0
Compare
Before we would only load one policy file.
This also allows us to replace data items for tests.
qlonik
force-pushed
the
opa-rego-changes
branch
from
ca8d0a0 to
946ba79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors opa server and changes the policy for new input format.
Related to #55