This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
20 add popups handling #117
Open
JelenaRy
wants to merge
6
commits into
master
Choose a base branch
from
20-add-popups-handling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JelenaRy
commented
May 28, 2021
- Added 2 functions to Helpers class to handle popups
- Added tests to helpers.test.js
- Updated Element class to contain page property (uses global page by default)
- Updated Interceptor class to contain page property (uses global page by default)
- Updated tests in interceptor.test.js to use added page property
- Updated selector in one of tests in elementActions.test.js
JelenaRy
requested review from
Martynienas,
ernestas-zekas,
vaidasmaciulis and
jevgenijusmarinuskinas
May 28, 2021 08:00
jevgenijusmarinuskinas
previously approved these changes
May 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge latest master to branch
@@ -2,23 +2,30 @@ import { Element, Interceptor } from "test-juggler"; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 tests are failing in interceptor suite:
Interceptor
√ should block requests by any url fragment using Regex pattern while test case running (7423 ms)
√ should block requests by any url fragment using Glob pattern after abort method is used (3831 ms)
√ should block request by any url fragment after action (3455 ms)
× should block any request after action (30176 ms)
√ should count all requests (368 ms)
× should detect specific response after action (30182 ms)
× should detect any request after action (3 ms)
|
||
//Act | ||
await pageWithDismissAlertsSetup.goto("http://the-internet.herokuapp.com/javascript_alerts"); | ||
await pageWithDismissAlertsSetup.click("button[onclick='jsAlert()']"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two lint issues:
C:\source\test-juggler\example\tests\helpers.test.js
107:1 error Mixed spaces and tabs no-mixed-spaces-and-tabs
122:1 error Mixed spaces and tabs no-mixed-spaces-and-tabs
✖ 2 problems (2 errors, 0 warnings)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.