Skip to content

Commit

Permalink
Improved docs for from_url (#138)
Browse files Browse the repository at this point in the history
  • Loading branch information
kylebarron authored Jan 14, 2025
1 parent 185bd05 commit cc7c2fa
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 0 deletions.
5 changes: 5 additions & 0 deletions obstore/python/obstore/store/_aws.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,11 @@ class S3Store:
- `https://<bucket>.s3.<region>.amazonaws.com`
- `https://ACCOUNT_ID.r2.cloudflarestorage.com/bucket`
!!! note
Note that `from_url` will not use any additional parts of the path as a
bucket prefix. It will only extract the bucket, region, and endpoint. If you
wish to use a path prefix, consider wrapping this with `PrefixStore`.
Args:
url: well-known storage URL.
Expand Down
5 changes: 5 additions & 0 deletions obstore/python/obstore/store/_azure.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,11 @@ class AzureStore:
- `https://<account>.blob.fabric.microsoft.com`
- `https://<account>.blob.fabric.microsoft.com/<container>`
!!! note
Note that `from_url` will not use any additional parts of the path as a
bucket prefix. It will only extract the container name, account name, and
whether it's a fabric endpoint. If you wish to use a path prefix, consider
wrapping this with `PrefixStore`.
Args:
url: well-known storage URL.
Expand Down
5 changes: 5 additions & 0 deletions obstore/python/obstore/store/_gcs.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,11 @@ class GCSStore:
- `gs://<bucket>/<path>`
!!! note
Note that `from_url` will not use any additional parts of the path as a
bucket prefix. It will only extract the bucket name. If you wish to use a
path prefix, consider wrapping this with `PrefixStore`.
Args:
url: well-known storage URL.
Expand Down
4 changes: 4 additions & 0 deletions obstore/python/obstore/store/_http.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ class HTTPStore:
) -> HTTPStore:
"""Construct a new HTTPStore from a URL
!!! note
Note that in contrast to the other stores, `from_url` **will** use the full
URL provided here as a prefix for further operations.
Args:
url: The base URL to use for the store.
Expand Down

0 comments on commit cc7c2fa

Please sign in to comment.