Skip to content

Commit

Permalink
feat(all): fix ci in combine ci and cov
Browse files Browse the repository at this point in the history
  • Loading branch information
devillove084 committed Mar 9, 2024
1 parent 8a86c87 commit 4324427
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 47 deletions.
38 changes: 37 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,40 @@ jobs:
if: ${{ matrix.os == 'ubuntu-latest' || matrix.os == 'macos-14' }}
env:
NEXTEST_DOUBLE_SPAWN: 0
run: cargo local-nt run --profile ci
run: cargo local-nt run --profile ci

coverage:
name: Collect test coverage
runs-on: ubuntu-latest
# nightly rust might break from time to time
continue-on-error: true
env:
RUSTFLAGS: -D warnings
CARGO_TERM_COLOR: always
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
# Nightly Rust is used for cargo llvm-cov --doc below.
- name: Install Protoc
uses: arduino/setup-protoc@v3
- uses: dtolnay/rust-toolchain@nightly
with:
components: llvm-tools-preview
- uses: Swatinem/rust-cache@23bce251a8cd2ffc3c1075eaa2367cf899916d84 # v2

- name: Install latest nextest release
uses: taiki-e/install-action@nextest
- name: Install cargo-llvm-cov
uses: taiki-e/install-action@cargo-llvm-cov

- name: Collect coverage data
# Generate separate reports for nextest and doctests, and combine them.
run: |
cargo llvm-cov --no-report nextest
cargo llvm-cov --no-report --doc
cargo llvm-cov report --doctests --lcov --output-path lcov.info
- name: Upload coverage data to codecov
uses: codecov/[email protected] # v4
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
with:
files: lcov.info
45 changes: 0 additions & 45 deletions .github/workflows/coverage.yml

This file was deleted.

2 changes: 1 addition & 1 deletion src/storage_engine/src/cache/bloom_filter_cache.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ impl BloomFilter {
}
}
fn bloom_hash(data: &[u8]) -> u32 {
hash(data, 0xc6a4a793)
hash(data, 0xc6a4_a793)
}
}

Expand Down

0 comments on commit 4324427

Please sign in to comment.