compiler: Optimize normalize_reduction_sparse #2314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloubout
force-pushed
the
sparse-normalize-optim
branch
from
b316d59 to
799a3c5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2314 +/- ##
==========================================
- Coverage 86.69% 86.68% -0.01%
==========================================
Files 229 229
Lines 42983 43006 +23
Branches 7967 7971 +4
==========================================
+ Hits 37262 37281 +19
- Misses 5033 5034 +1
- Partials 688 691 +3 ☔ View full report in Codecov by Sentry. |
mloubout
force-pushed
the
sparse-normalize-optim
branch
3 times, most recently
from
f68a895 to
7091432
Compare
compiler: Optimize normalize_reductions_sparse
mloubout
force-pushed
the
sparse-normalize-optim
branch
4 times, most recently
from
9b92d6b to
7ab09f7
Compare
mloubout
force-pushed
the
sparse-normalize-optim
branch
from
7ab09f7 to
efa1368
Compare
| @@ -118,6 +118,39 @@ def operation(self, **kwargs): | |||
| def __repr__(self): | |||
| return "Injection(%s into %s)" % (repr(self.expr), repr(self.field)) | |||
|
|
|||
| def __add__(self, other): | |||
| # If the next equation is the same type and sparse function | |||
There was a problem hiding this comment.
couple of typos in this paragraph
|
|
||
| def _merge(self, other, left=False): | ||
| s1, s2 = (other, self) if left else (self, other) | ||
| if isinstance(other, Injection) and \ |
There was a problem hiding this comment.
nitpicking
convention for many-characters if ... and/or ... is as follows:
if cond_A and \
cond_B and \
cond_C:
<...>
| bns, _ = assert_blocking(op0, {}) | ||
| bns, _ = assert_blocking(op1, {'x0_blk0'}) # due to loop blocking | ||
|
|
||
| assert summary0[('section0', None)].ops == 50 | ||
| assert summary0[('section1', None)].ops == 44 | ||
| assert summary0[('section1', None)].ops == 61 |
There was a problem hiding this comment.
wait why an increase?
| v = Symbol(name=name, dtype=e.dtype) | ||
| processed.extend([e.func(v, e.rhs, operation=None), | ||
| e.func(e.lhs, v)]) | ||
| if e.rhs in mapper: |
There was a problem hiding this comment.
note that just like normalize_reductions_dense this is flaky if for whatever reason one Eq writes to e.rhs in between these clusters, as it would violate a data dependence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.