This repository has been archived by the owner on Jul 21, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Add check for image files (organizer, speaker and sponsor) - Fix #573 #668
Open
somatorio
wants to merge
18
commits into
devopsdays:master
Choose a base branch
from
somatorio:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Stratton <[email protected]>
This ensures that it new events without speakers can use the speaker template without errors. Signed-off-by: Matt Stratton <[email protected]>
Instead of serving it remotely from netlify. Now we have control of it. Signed-off-by: Matt Stratton <[email protected]>
Signed-off-by: Matt Stratton <[email protected]>
Signed-off-by: Matt Stratton <[email protected]>
Fixes devopsdays#678 Signed-off-by: Matt Stratton <[email protected]>
I noticed that some "missing" files were actually at "content/" dir, so i added a check at this directory |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please notice that this pr checks will likely fail, as my testing building was giving me A LOT of "image file missing" as you can see on the log below (you can also see that the return code wasn't 0)... but the building was working ok, just replacing the images with the same massage from the error when the image couldn't be found
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)