EES-5820 - rewriting "Location" response headers to replace static webapp FQDN with public FQDN #5599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bapp FQDN with public FQDN
duncan-at-hiveit
force-pushed
the
EES-5820-fix-trailing-slash-redirects-in-static-webapp
branch
from
dbe9653 to
41454ae
Compare
tomjonesdev
approved these changes
Feb 17, 2025
duncan-at-hiveit
deleted the
EES-5820-fix-trailing-slash-redirects-in-static-webapp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Previously if navigating to a docs URL without a trailing slash, the static webapp (being configured with
"trailingSlash": "auto") would redirect to a version of the URL with a trailing slash added. Unfortunately it would implement this as a redirect to an absolute URL with the static webapp's FQDN included.Thus, navigating to:
https://pp-api.education.gov.uk/statistics-dev/docs/getting-started
would redirect to:
https://witty-bay-020052c03.4.azurestaticapps.net/getting-started/
It doesn't seem like there is any way to override this trailing slash redirect behaviour from the static webapp.
The solution
Looking into this, it was using the HTTP response's "Location" header to instruct the browser to redirect permanently to the
https://witty-bay-020052c03.4.azurestaticapps.net/getting-started/URL.Seeing as we couldn't configure the webapp to change its behaviour, instead we use Application Gateway to rewrite the response's Location header. We look for Location headers of the form
https://witty-bay-020052c03.4.azurestaticapps.net/*and rewrite them to behttps://pp-api.education.gov.uk/statistics-dev/docs/*instead.