Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump candid to 0.9 #448

Merged
merged 13 commits into from
Jul 5, 2023
Merged

chore: bump candid to 0.9 #448

merged 13 commits into from
Jul 5, 2023

Conversation

chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity commented Jul 3, 2023 •
edited
Loading

Description

Bump Candid to 0.9. No user visible change is expected.

A backlog item to refactor ic-utils is added in #449

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@chenyan-dfinity chenyan-dfinity requested a review from a team as a code owner July 3, 2023 17:09
@chenyan-dfinity chenyan-dfinity mentioned this pull request Jul 3, 2023
Open
ericswanson-dfinity
ericswanson-dfinity requested changes Jul 5, 2023
View reviewed changes
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add note to changelog

@lwshang
Copy link
Contributor

lwshang commented Jul 5, 2023

candid major version upgrade should result in major version bump of agent-rs crates.

@ericswanson-dfinity ericswanson-dfinity merged commit c75c894 into dfinity:main Jul 5, 2023
@chenyan-dfinity chenyan-dfinity deleted the bump-candid branch July 5, 2023 20:05
@ericswanson-dfinity ericswanson-dfinity mentioned this pull request Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenyan-dfinity @lwshang @ericswanson-dfinity