Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sns): Add UpgradeSnsControlledCanister #169

Merged
merged 1 commit into from
Feb 4, 2025
Merged

feat(sns): Add UpgradeSnsControlledCanister #169

merged 1 commit into from
Feb 4, 2025

Conversation

anchpop
Copy link
Contributor

@anchpop anchpop commented Feb 4, 2025 •
edited
Loading

This PR also allows the SNS extension inherit the DFX identity from the user's DFX settings.

@anchpop anchpop force-pushed the @anchpop/update-version branch 4 times, most recently from 8db36b0 to b7cf6f3 Compare February 4, 2025 05:36
@anchpop anchpop marked this pull request as ready for review February 4, 2025 05:56
@anchpop anchpop requested review from a team as code owners February 4, 2025 05:56
@anchpop anchpop changed the title Add UpgradeSnsControlledCanister feat(sns): Add UpgradeSnsControlledCanister Feb 4, 2025
@anchpop anchpop force-pushed the @anchpop/update-version branch from b7cf6f3 to 9116544 Compare February 4, 2025 05:58
sesi200
sesi200 previously approved these changes Feb 4, 2025
View reviewed changes
max-dfinity
max-dfinity previously approved these changes Feb 4, 2025
View reviewed changes
@max-dfinity
Copy link

LGTM, but please address comments before merging

@anchpop anchpop dismissed stale reviews from max-dfinity and sesi200 via 47392f9 February 4, 2025 17:05
@anchpop anchpop force-pushed the @anchpop/update-version branch from 9116544 to 47392f9 Compare February 4, 2025 17:05
@anchpop anchpop enabled auto-merge (squash) February 4, 2025 17:06
@anchpop anchpop force-pushed the @anchpop/update-version branch from 47392f9 to ca320cf Compare February 4, 2025 17:11
@anchpop anchpop merged commit 9ad8771 into main Feb 4, 2025
11 checks passed
@anchpop anchpop deleted the @anchpop/update-version branch February 4, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sesi200 sesi200 sesi200 approved these changes

@max-dfinity max-dfinity max-dfinity left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anchpop @max-dfinity @sesi200