Configure ESBuild to rewrite global as globalThis
#136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I apologize, I might have spoken too soon. While this did resolve the initial problem of creating web workers in the first place, two other related issues came up--I'll setup a clean project and provide more details (BigInt serialization became an issue, and a lack of process.env specifically in the webworker). |
|
All good! This is still a reasonable improvement by itself. Regarding BigInt serialization, the code snippet in dfinity/agent-js#655 might work as a temporary solution. Definitely let me know if you make headway with setting up web workers, and we will update the starter projects accordingly. |
matthewhammer
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a potential issue with web workers described in rvanasa/vite-react-motoko#3.