-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Governance pull request template daniel wong #3321
Governance pull request template daniel wong #3321
Conversation
…ow another way. Normally, I would be able to run my code before committing. I do not know of a way to do that when developing a GH Actions.
- uses: actions/github-script@v6 | ||
id: isAuthorInNnsTeam | ||
with: | ||
github-token: ${{ secrets.CLA_BOT_PRIVATE_KEY }} | ||
result-encoding: string | ||
retries: 3 | ||
script: | | ||
const pullRequestNumber = context.payload.number; | ||
console.log("Calling listMembersInOrg...") | ||
const nnsTeamMembers = await await github.rest.teams.listMembersInOrg({ | ||
org: "dfinity", | ||
team_slug: "nns-team", | ||
}); | ||
console.log("nnsTeamMemebrs = " + JSON.stringify(nnsTeamMembers)); | ||
|
||
const isInNnsTeam = nnsTeamMembers.data.some(member => member.login == context.actor); | ||
console.log("Is actor in nns-team? " + isInNNsTeam); | ||
return isInNnsTeam | ||
|
||
- uses: actions/github-script@v6 | ||
if: steps.isAuthorInNnsTeam == 'true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to use CLA_BOT_PRIVATE_KEY.
…to see if the rest of the workflow/action works.
…to see if the rest of the workflow/action works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you remember to update unreleased_changes.md? If so, please, explicitly acknowledge this reminder by giving it a thumbs up reaction. To unblock the PR, dismiss the code review by going to the bottom of the pull request page, and use "Done." as the reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you remember to update unreleased_changes.md? If so, please, explicitly acknowledge this reminder by giving it a thumbs up reaction. To unblock the PR, dismiss the code review by going to the bottom of the pull request page, and use "Done." as the reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you remember to update unreleased_changes.md? If so, please, explicitly acknowledge this reminder by giving it a thumbs up reaction. To unblock the PR, dismiss the code review by going to the bottom of the pull request page, and use "Done." as the reason.
…log.md), added a whole bunch of possible events that can trigger the reminder.
Hello, GitHub!