Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(governance): Automatically remind governance team to update unreleased_changelog.md. #3342

Conversation

daniel-wong-dfinity-org
Copy link
Contributor

@daniel-wong-dfinity-org daniel-wong-dfinity-org commented Jan 6, 2025

This happens via a new GitHub Action. What it does is

if review is not requested from nns-team {
  return;
}

if already reminded {
  return;
}

Add a review that reminds the author that they need to update unreleased_changelog.md.

Because the reminder is done as a code review, the author is FORCED to acknowledge the reminder.

@daniel-wong-dfinity-org daniel-wong-dfinity-org requested a review from a team January 6, 2025 18:58
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you remember to update unreleased_changes.md? If so (or if this is notnecessary), please, explicitly acknowledge this reminder by giving it athumbs up reaction. To unblock the PR, dismiss the code review by goingto the bottom of the pull request page, and use "Done." as the reason.

@github-actions github-actions bot added the feat label Jan 6, 2025
@daniel-wong-dfinity-org daniel-wong-dfinity-org dismissed github-actions[bot]’s stale review January 6, 2025 18:59

This change does not affect the behavior of any governance canister.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).

To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:

  1. Done.

  2. No canister behavior changes.

@daniel-wong-dfinity-org daniel-wong-dfinity-org marked this pull request as draft January 7, 2025 13:00
@daniel-wong-dfinity-org daniel-wong-dfinity-org marked this pull request as ready for review January 7, 2025 13:00
@daniel-wong-dfinity-org daniel-wong-dfinity-org force-pushed the automatically-remind-governance-team-to-update-unreleased_changelog_md-daniel-wong branch from ac0b8de to 542a5ac Compare January 7, 2025 13:03
@daniel-wong-dfinity-org daniel-wong-dfinity-org added this pull request to the merge queue Jan 7, 2025
Merged via the queue into master with commit 43e661e Jan 7, 2025
26 checks passed
@daniel-wong-dfinity-org daniel-wong-dfinity-org deleted the automatically-remind-governance-team-to-update-unreleased_changelog_md-daniel-wong branch January 7, 2025 16:56
github-merge-queue bot pushed a commit that referenced this pull request Jan 8, 2025
…overnance. (#3332)

If this works, we will do the same thing to other canisters that we (the
Governance team) own. Automation will be implemented in other PRs.

# References

## Follow Up Pull Requests

[Remind the team to update unreleased_changelog.md][remind] (if it
exists).

[remind]: #3342

[Automate proposal generation][propose].

[propose]: #3353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants