-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(governance): Automatically remind governance team to update unreleased_changelog.md. #3342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you remember to update unreleased_changes.md? If so (or if this is notnecessary), please, explicitly acknowledge this reminder by giving it athumbs up reaction. To unblock the PR, dismiss the code review by goingto the bottom of the pull request page, and use "Done." as the reason.
This change does not affect the behavior of any governance canister.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
No canister behavior changes.
ac0b8de
to
542a5ac
Compare
…this is what reviewers (plural) want.
…overnance. (#3332) If this works, we will do the same thing to other canisters that we (the Governance team) own. Automation will be implemented in other PRs. # References ## Follow Up Pull Requests [Remind the team to update unreleased_changelog.md][remind] (if it exists). [remind]: #3342 [Automate proposal generation][propose]. [propose]: #3353
This happens via a new GitHub Action. What it does is
Because the reminder is done as a code review, the author is FORCED to acknowledge the reminder.