Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to mark PR as ready after tests pass #6427

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Script to mark PR as ready after tests pass #6427

merged 2 commits into from
Feb 14, 2025

Conversation

dskloetd
Copy link
Contributor

Motivation

I like to make sure tests pass before marking a PR as ready to review.
But this means I have to remember to get back to the PR to check if the tests passed and then mark it ready for review.

Changes

Add scripts/github-mark-ready which watches a specified PR and marks it as ready for review after the tests have passed.
Optionally marking it as "merge when ready".

Tests

Used manually for 2 separate PRs.

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review February 14, 2025 13:24
@dskloetd dskloetd requested a review from a team as a code owner February 14, 2025 13:25
@dskloetd dskloetd enabled auto-merge February 14, 2025 13:25
Copy link
Contributor

@yhabib yhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@dskloetd dskloetd added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit 72be7c1 Feb 14, 2025
32 checks passed
@dskloetd dskloetd deleted the kloet/mark-ready branch February 14, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants