Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose types for consumers of the lib #47

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Aug 7, 2024

Motivation

Consumers of the libs should be able to use the TS types in their projects.

Changes

  • Expose the types at the root of the library.

Example

import { Wallet } from '@dfinity/oisy-wallet-signer/wallet';
import type {IcrcSupportedStandards} from "@dfinity/oisy-wallet-signer";

const wallet = await Wallet.connect({
    url: 'http://localhost:5174'
});

let supportedStandards: IcrcSupportedStandards | undefined = undefined;

@peterpeterparker peterpeterparker requested a review from a team as a code owner August 7, 2024 12:51
@peterpeterparker peterpeterparker merged commit 9912632 into main Aug 7, 2024
7 checks passed
@peterpeterparker peterpeterparker deleted the feat/expose-types branch August 7, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant