Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add todo for wallet popup close #52

Merged
merged 1 commit into from
Aug 8, 2024
Merged

chore: add todo for wallet popup close #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ export class Wallet {
readonly #origin: string;
readonly #popup: Window;

// TODO: we cannot destroy the wallet but the popup might be destroyed / closed manually
// - should we set origin and popup to null when closed?
// - should we expose a callback event to inform the consumer?
//
// PS: setInterval(() => if popup.closed {reset}, 1000)

private constructor({origin, popup}: {origin: string; popup: Window}) {
this.#origin = origin;
this.#popup = popup;
Expand Down