Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Condense output of dfx start/stop #4084

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

adamspofford-dfinity
Copy link
Contributor

@adamspofford-dfinity adamspofford-dfinity commented Jan 29, 2025

@adamspofford-dfinity adamspofford-dfinity marked this pull request as ready for review January 29, 2025 23:44
@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner January 29, 2025 23:44
Copy link
Contributor

@krpeacock krpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of posterity, can you drop the before/after text in this PR as a comment?

@adamspofford-dfinity
Copy link
Contributor Author

Before:

Running dfx start for version 0.24.3
Using shared network 'local' defined in ~/.config/dfx/networks.json
Initialized replica.
Initialized HTTP gateway.
Replica API running on 127.0.0.1:4943
Success! The dfx server is running in the background.
# or:
Success! The dfx server is running.
You must open a new terminal to continue developing. If you'd prefer to stop, quit with 'Ctrl-C'.

After:

Running dfx start for version 0.25.0-beta.0+rev2.bc153f97
Using shared network 'local' defined in ~/.config/dfx/networks.json
Replica API running in the background on 127.0.0.1:4943
# or:
Replica API running on 127.0.0.1:4943. You must open a new terminal to continue developing. If you'd prefer to stop, quit with 'Ctrl-C'.

Before:

Using shared network 'local' defined in ~/.config/dfx/networks.json
Stopping canister http adapter...
Stopped.
Stopping the replica...
Stopped.
Stopping HTTP gateway...
Stopped.

After:

Using shared network 'local' defined in ~/.config/dfx/networks.json
All local network processes stopped

@adamspofford-dfinity adamspofford-dfinity merged commit b1a3a2e into master Jan 30, 2025
297 checks passed
@adamspofford-dfinity adamspofford-dfinity deleted the spofford/start-output branch January 30, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants