chore: update tests to show asset canister properly handles special chars #4103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-assets-with-filenames-containing-certain-characters
ericswanson-dfinity
approved these changes
Feb 10, 2025
sesi200
deleted the
SDK-1420-asset-canister-can-no-longer-serve-assets-with-filenames-containing-certain-characters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A while back the asset canister did not handle special characters in file names correctly. This was recorded in e2e tests and recorder for follow-up in SDK-1247/1420. The behavior was fixed in #3767. This PR now updates the tests to demonstrate more clearly that special characters are handled properly.
Fixes SDK-1420
How Has This Been Tested?
Updated e2e tests to demonstrate correct behavior
Checklist: