Skip to content

Commit

Permalink
libfdt: Remove fdt parameter from overlay_fixup_one_phandle
Browse files Browse the repository at this point in the history
When compiling with -Wall -Wextra, the unused fdt parameter becomes a
warning. With -Werror, it becomes an error and fails the build.

As the parameter is not used in the function, let's remove it.

Signed-off-by: Bingwu Zhang <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: David Gibson <[email protected]>
  • Loading branch information
xtexChooser authored and dgibson committed Nov 25, 2024
1 parent b3bbee6 commit 1c745a9
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions libfdt/fdt_overlay.c
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,6 @@ static int overlay_update_local_references(void *fdto, uint32_t delta)

/**
* overlay_fixup_one_phandle - Set an overlay phandle to the base one
* @fdt: Base Device Tree blob
* @fdto: Device tree overlay blob
* @symbols_off: Node offset of the symbols node in the base device tree
* @path: Path to a node holding a phandle in the overlay
Expand All @@ -328,8 +327,7 @@ static int overlay_update_local_references(void *fdto, uint32_t delta)
* 0 on success
* Negative error code on failure
*/
static int overlay_fixup_one_phandle(void *fdt, void *fdto,
int symbols_off,
static int overlay_fixup_one_phandle(void *fdto, int symbols_off,
const char *path, uint32_t path_len,
const char *name, uint32_t name_len,
int poffset, uint32_t phandle)
Expand Down Expand Up @@ -443,7 +441,7 @@ static int overlay_fixup_phandle(void *fdt, void *fdto, int symbols_off,
if ((*endptr != '\0') || (endptr <= (sep + 1)))
return -FDT_ERR_BADOVERLAY;

ret = overlay_fixup_one_phandle(fdt, fdto, symbols_off,
ret = overlay_fixup_one_phandle(fdto, symbols_off,
path, path_len, name, name_len,
poffset, phandle);
if (ret)
Expand Down

0 comments on commit 1c745a9

Please sign in to comment.