Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix -Dtools=false build #155

Merged
merged 1 commit into from
Dec 18, 2024
Merged

build: fix -Dtools=false build #155

merged 1 commit into from
Dec 18, 2024

Conversation

elmarco
Copy link
Contributor

@elmarco elmarco commented Nov 11, 2024

Fixes:
tests/meson.build:107:27: ERROR: Unknown variable "util_dep"

blmaier
blmaier reviewed Nov 11, 2024
View reviewed changes
meson.build Outdated Show resolved Hide resolved
@dgibson
Copy link
Owner

dgibson commented Nov 13, 2024

Fix itself looks fine to me. The commit message needs a little work. It has what looks like a Fixes: tag, but it's neither kernel format (pointing to a commit which introduced the bug) nor github format (pointing to an issue describing the problem). I'd appreciate a little more context about what went wrong here too.

@elmarco
build: fix -Dtools=false build
6203dc4 
When configuring the project, meson fails with:
tests/meson.build:107:27: ERROR: Unknown variable "util_dep"

Declare the util_dep dependency regardless if 'tools' are enabled, so
tests can be built with it.

Fixes: bdc5c87 ("meson: allow disabling tests")
Signed-off-by: Marc-André Lureau <[email protected]>
@blmaier
Copy link
Contributor

blmaier commented Dec 17, 2024

@dgibson can this PR be merged?

@dgibson dgibson merged commit 18f4f30 into dgibson:main Dec 18, 2024
12 checks passed
@dgibson
Copy link
Owner

dgibson commented Dec 18, 2024

I've merged this. However, I'm not sure the fix is complete, -Dtools=false build still fails for me, but now it does it at the meson test stage instead of the meson setup stage. @elmarco any ideas?

@blmaier
Copy link
Contributor

blmaier commented Dec 18, 2024

Some of the failing tests are because it tries to run the tool tests, that should be an easy fix.

However libfdt tests fail because some of the tests need a dtb, and it compiles them from a dts. Not sure how to fix that, it seems having tools enabled is a prerequisite for any of the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blmaier blmaier blmaier left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elmarco @dgibson @blmaier