feat(Finder): Finder 컴포넌트 구현 #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzi-0
reviewed
May 30, 2023
| }; | ||
|
|
||
| const onFocus = () => setActivatedIcon(icon); | ||
|
|
||
| const onDoubleClick = (id: DesktopIcon['type']) => { |
There was a problem hiding this comment.
id보다는 type이 좀 더 명확한 변수명 같아요!
| case 'browser': | ||
| window.open(GITHUB_URL); | ||
| break; | ||
| case 'finder': |
There was a problem hiding this comment.
finder에서 내용이 빠져있는데 뭘해주는건가요..?
| import { finderSidebarContents } from '@/data/menu/finder-sidebar'; | ||
|
|
||
| export interface TitleBarProps { | ||
| location: string; |
There was a problem hiding this comment.
최근항목, 응용프로그램, 문서 등 정해져있어서 string 타입보다는 리터럴 타입을 쓰는 것이 좋을 것 같아요~ 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑💻 작업 사항
🐰 시급한 정도
🏃♂️ 보통 : 최대한 빠르게 리뷰 부탁드립니다.
📖 참고 사항