Enable lexical binding - and some other stuff #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docstrings of mmm-ify and mmm-match region requires more thought.
Simplify by using pos-[be]ol instead of excursions.
The mmm class property :case-fold-search is passed as a keyword argument to mmm-ify. But that argument would shadow the dynamic variable with the same name. Use the name case-fold-search-arg with a :case-fold-search keyword to avoid that problem. The argument was used instead of a let-bound variable, so add a let binding of case-fold-search around the function body.
boundp does not work with lexical variables. Just use them and ignore the errors. ignore-error is not available until Emacs 27.1, use explicit condition-case instead.
Instead of the obsolete point-at-bol.
dgutov
reviewed
Feb 20, 2024
dgutov
reviewed
Feb 20, 2024
|
Thank you, excellent job. Just two minor questions, see above. |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
lexical-bindingin all code and test files.Some small changes were required.
While reading through all files I also tweaked most docstrings to pass
checkdoc.Also enabled CI testing for Emacs 29.1 and 29.2.
Added a test to check that
mmm-versionmatches theVersiontag.