Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: adjust the level of the root when deleting nodes #57

Closed

Conversation

tyrzhang
Copy link

bugfix: adjust the level of the root when deleting nodes

when the tree is deep, and deleting nodes, will cause the issue.
the tree could be like this: one obj but 3 levels depth.

{
  "size": 1,
  "depth": 3,
  "root": {
    "entries": [
      {
        "bb": "[1.00, 2.00]x[1.00, 2.00]",
        "child": {
          "entries": [
            {
              "bb": "[1.00, 2.00]x[1.00, 2.00]",
              "child": {
                "leaf": true,
                "entries": [
                  {
                    "bb": "[1.00, 2.00]x[1.00, 2.00]"
                  }
                ]
              }
            }
          ]
        }
      }
    ]
  }
}

so we need to merge the root in loop, instead of once.

@dhconnelly
Copy link
Owner

thank you for the contribution! would you mind splitting the new code that implements Stringer into a separate PR?

@dhconnelly dhconnelly force-pushed the bugfix/tyr_delete_last_one branch from 97c918f to 78df826 Compare December 19, 2024 17:03
@dhconnelly
Copy link
Owner

fixed the lint issue and rebased your PR, sorry for the trouble

@dhconnelly
Copy link
Owner

sorry, should have merged master instead of rebased, you'll have to re-force push

@tyrzhang
Copy link
Author

ok, I'll separate a new PR for the Stringer implements.

@tyrzhang tyrzhang closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants