Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update homepage to design system and reorganize some content #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lukehollis
Copy link

Hey @ryaanahmed, I updated the homepage to the latest design system while hopefully making the project look somewhat independent while remaining as syndicated content to the main brand. Let me know if this is a good direction, and I'll continue updating the rest of the pages on the project. Some responsive fixes need to be added.

screencapture-127-0-0-1-8021-2020-05-08-21_24_29

Copy link
Member

@ryaanahmed ryaanahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - great direction! Sorry for taking ages to review -- here are some comments, but nothing blocking merge:

  • Can we find some way to even more clearly give this project its own visual identity? The later projects had a more distinct independent visual identity, whereas this one didn't really. I like the use of the main design system, but let's try to find just one visual hook to say "this is its own thing".

  • Let's make a prominent link to the code repo on GitHub on the project page, both to the original project and the gender analysis toolkit

great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants