Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anagram #7

Merged
merged 104 commits into from
Feb 2, 2021
Merged

Anagram #7

merged 104 commits into from
Feb 2, 2021

Conversation

taokinbo
Copy link
Contributor

@taokinbo taokinbo commented Jan 26, 2021

In this pull request, we have added an anagram game with the features of:

  • Word bank with shuffle options
  • A give up and Restart button
  • Scoring System (target word adds point value of 2 times the length of word. Extra words add only length of word)
  • Definitions (with additional definitions for each target word when hovered)
  • Examples (when hovered over the target words)
  • Instructions Modal (actual instructions will be inputed later)
  • Timer
  • Loading Screen
  • Game over functions
  • A Landing Page contain the main text and game options for different parts of speech for the anagram games.
  • A color scheme that matches quiz page.

image
image
image
image
Screen Shot 2021-01-27 at 5 05 13 PM

image
image

@ryaanahmed

JasonLin43212 and others added 30 commits January 21, 2021 12:35
get_part_of_speech_words now expands contractions before tokenizing
@JasonLin43212 JasonLin43212 linked an issue Jan 26, 2021 that may be closed by this pull request
15 tasks
@taokinbo taokinbo self-assigned this Jan 26, 2021
Copy link
Member

@ryaanahmed ryaanahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is SO GOOD. I don't even have any of my usual nitpicky code style feedback: the code is beautifully easy to read, documented, well structured, and tested. Fantastic work.

I removed the dependency_parsing module taken from Gender Analysis Toolkit, as in the end this project wasn't using it.

I have some comments, but these should be taken as directions for further work and refinement -- nothing here prevents me merging.

  1. Let's add mode where the pool of available letters is separated by words (so it's a classic anagram per word, not an anagram of all the words all mixed together. As is, the game is pretty hard!
  2. After hitting "Give up" add a distinction between in "Words found" between words that the student found and those given by the answer key.
  3. "Extra words" isn't really clear: took me a little experimenting to figure out what that was about. Plus it shows the confetti animation, even though those aren't correct answers.
  4. Needs some responsive design work: I think this interface is totally feasible to make work at the narrower screen sizes, but right now the main columns in the interface squish together instead of stacking.
  5. Add instructions in the placeholder place and show that modal by default when you open the game.
  6. The hover definitions feature wasn't very clear to me when I first hovered: I was confused about what I was seeing. Maybe that could be more apparent in the interface or labeled better? (Even "other definitions" would make it clearer)

Merging. Fantastic work. (If folks on the team could make some follow up issues from the comments above, would be great...)

@ryaanahmed ryaanahmed merged commit feaf9f0 into master Feb 2, 2021
@ryaanahmed ryaanahmed deleted the anagram branch February 2, 2021 17:45
@ryaanahmed ryaanahmed mentioned this pull request Feb 2, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anagram
10 participants