fix: skip logfire intialization if inside github workflow (#28)

dhruv-ahuja · Aug 24, 2024 · a6c095e · a6c095e
1 parent 2e6a514
commit a6c095e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml
@@ -11,6 +11,9 @@ concurrency:
     group: ${{ github.workflow }}-${{ github.ref }}
     cancel-in-progress: true
 
+env:
+    APP_ENVIRONMENT: github_workflow
+
 jobs:
     deploy:
         runs-on: ubuntu-latest

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -24,6 +24,7 @@ env:
     S3_BUCKET_NAME: ${{secrets.S3_BUCKET_NAME}}
     S3_LOGS_FOLDER: ${{secrets.S3_LOGS_FOLDER}}
     REDIS_HOST: localhost
+    APP_ENVIRONMENT: github_workflow
 
 jobs:
     build:

diff --git a/src/config/services.py b/src/config/services.py
@@ -59,6 +59,7 @@ class Settings(BaseSettings):
 
     redis_host: str
     redis_password: SecretStr | None = None
+    app_environment: str
 
 
 def generate_settings_config(env_location: str | None = None) -> Settings:
@@ -76,6 +77,10 @@ def generate_settings_config(env_location: str | None = None) -> Settings:
 def initialize_logfire_services(app: FastAPI) -> None:
     """Initializes LogFire services by configuring and initializing its client, and registering requisite services."""
 
+    # skip as requisite env vars wont be available
+    if settings.app_environment == "github_workflow":
+        return
+
     logfire.configure()
     logfire.instrument_fastapi(app)
     logfire.instrument_redis()