Fix Nested Filter-Sort and Model Querying Issues #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure each filter is applied only once per query - fix failures on nested filtering
dhruv-ahuja
added a commit
that referenced
this pull request
Aug 29, 2024
* refactor: make filter operators constant * fix: resolve filtering issues - ensure each filter is applied only once per query - fix failures on nested filtering * fix: allow nested sorting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #25's changes broke filter and sort functionality for nested columns. This PR addresses those issues by using raw Mongo syntax and avoiding extracting model attributes for such filter/sort parameters.
This also prevents duplication of filter-sort parameters on successive queries that happened due to the re-use of the same
queryobject for bothcountand the actual fetch queries.