Merge pull request statsd#296 from etsy/pet_syntaxchecker

add jshint comment and do a little cleanup

backends/console.js

@@ -1,3 +1,5 @@
+/*jshint node:true, laxcomma:true */
+
 var util = require('util');
 
 function ConsoleBackend(startupTime, config, emitter){
@@ -9,7 +11,7 @@ function ConsoleBackend(startupTime, config, emitter){
   // attach
   emitter.on('flush', function(timestamp, metrics) { self.flush(timestamp, metrics); });
   emitter.on('status', function(callback) { self.status(callback); });
-};
+}
 
 ConsoleBackend.prototype.flush = function(timestamp, metrics) {
   console.log('Flushing stats at', new Date(timestamp * 1000).toString());
@@ -22,7 +24,7 @@ ConsoleBackend.prototype.flush = function(timestamp, metrics) {
     counter_rates: metrics.counter_rates,
     sets: function (vals) {
       var ret = {};
-      for (val in vals) {
+      for (var val in vals) {
         ret[val] = vals[val].values();
       }
       return ret;

backends/graphite.js

@@ -1,3 +1,5 @@
+/*jshint node:true, laxcomma:true */
+
 /*
  * Flush stats to graphite (http://graphite.wikidot.com/).
  *

backends/repeater.js

@@ -1,8 +1,12 @@
-var util = require('util'),
-    dgram = require('dgram'),
-    logger = require('../lib/logger');
+/*jshint node:true, laxcomma:true */
+
+var util = require('util')
+  , dgram = require('dgram')
+  , logger = require('../lib/logger');
+
 var l;
 var debug;
+
 function RepeaterBackend(startupTime, config, emitter){
   var self = this;
   this.config = config.repeater || [];
@@ -17,7 +21,7 @@ function RepeaterBackend(startupTime, config, emitter){
   });
   // attach
   emitter.on('packet', function(packet, rinfo) { self.process(packet, rinfo); });
-};
+}
 
 RepeaterBackend.prototype.process = function(packet, rinfo) {
   var self = this;

lib/config.js

@@ -1,5 +1,7 @@
+/*jshint node:true, laxcomma:true */
+
 var fs  = require('fs')
-  , util = require('util')
+  , util = require('util');
 
 var Configurator = function (file) {
 

lib/logger.js

@@ -1,18 +1,20 @@
+/*jshint node:true, laxcomma:true */
+
 var Logger = function (config) {
   this.config  = config;
-  this.backend = this.config.backend || 'stdout'
-  this.level   = this.config.level || "LOG_INFO"
+  this.backend = this.config.backend || 'stdout';
+  this.level   = this.config.level || "LOG_INFO";
   if (this.backend == 'stdout') {
     this.util = require('util');
   } else {
     if (this.backend == 'syslog') {
       this.util = require('node-syslog');
       this.util.init(config.application || 'statsd', this.util.LOG_PID | this.util.LOG_ODELAY, this.util.LOG_LOCAL0);
     } else {
-      throw "Logger: Should be 'stdout' or 'syslog'."
+      throw "Logger: Should be 'stdout' or 'syslog'.";
     }
   }
-}
+};
 
 Logger.prototype = {
   log: function (msg, type) {
@@ -23,7 +25,7 @@ Logger.prototype = {
       this.util.log(type + ": " + msg);
     } else {
       if (!type) {
-        type = this.level
+        type = this.level;
         if (!this.util[type]) {
           throw "Undefined log level: " + type;
         }
@@ -33,6 +35,6 @@ Logger.prototype = {
       this.util.log(this.util[type], msg);
     }
   }
-}
+};
 
-exports.Logger = Logger
+exports.Logger = Logger;

lib/mgmt_console.js

@@ -1,3 +1,4 @@
+/*jshint node:true, laxcomma:true */
 
 /**
  * delete_stats - delete all matching statistics

lib/process_metrics.js

@@ -1,3 +1,5 @@
+/*jshint node:true, laxcomma:true */
+
 var process_metrics = function (metrics, flushInterval, ts, flushCallback) {
     var starttime = Date.now();
     var key;
@@ -122,6 +124,6 @@ var process_metrics = function (metrics, flushInterval, ts, flushCallback) {
     metrics.statsd_metrics = statsd_metrics;
 
     flushCallback(metrics);
-  }
+  };
 
-exports.process_metrics = process_metrics
+exports.process_metrics = process_metrics;

lib/set.js

@@ -1,6 +1,8 @@
+/*jshint node:true, laxcomma:true */
+
 var Set = function() {
   this.store = {};
-}
+};
 
 Set.prototype = {
   has: function(value) {
@@ -20,11 +22,11 @@ Set.prototype = {
   },
   values: function() {
     var values = [];
-    for (value in this.store) {
+    for (var value in this.store) {
       values.push(value);
     }
     return values;
   }
-}
+};
 
 exports.Set = Set;

stats.js

@@ -1,3 +1,5 @@
+/*jshint node:true, laxcomma:true */
+
 var dgram  = require('dgram')
   , util    = require('util')
   , net    = require('net')
@@ -7,7 +9,7 @@ var dgram  = require('dgram')
   , logger = require('./lib/logger')
   , set = require('./lib/set')
   , pm = require('./lib/process_metrics')
-  , mgmt = require('./lib/mgmt_console')
+  , mgmt = require('./lib/mgmt_console');
 
 
 // initialize data structures with defaults for statsd stats