Clip parsed level from debug console to 50 #6697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenCWills
requested changes
Oct 11, 2023
tetektoza
force-pushed
the
clip_parsed_level_to_50
branch
3 times, most recently
from
87a23fb to
6b5a715
Compare
StephenCWills
requested changes
Oct 11, 2023
tetektoza
force-pushed
the
clip_parsed_level_to_50
branch
from
6b5a715 to
fbff22a
Compare
ephphatha
reviewed
Oct 11, 2023
StephenCWills
requested changes
Oct 11, 2023
Currently, in givelvl command user can type lvl above 50, which is a level cap. This patch clips it to 50, so we can prevent an accidential freeze of the game caused by NetSendCmd loop if user types a really big number.
tetektoza
force-pushed
the
clip_parsed_level_to_50
branch
from
fbff22a to
adc91c3
Compare
StephenCWills
approved these changes
Oct 11, 2023
|
@tetektoza Welcome to the contributor list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in givelvl command user can type lvl above 50, which is a level cap. This patch clips it to 50, so we can prevent an accidential freeze of the game caused by NetSendCmd loop if user types a really big number.