Refactor: simplify logic in items.h #6699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJenbo
previously approved these changes
Oct 14, 2023
StephenCWills
requested changes
Oct 14, 2023
Currently some of the "isItem" functions add an unnecessary check of isEmpty which is redundant, because a few lines lower they also check for item type inside the same object. This patch removes those unnecessary checks.
tetektoza
force-pushed
the
simplify_logic_in_items_h
branch
from
e637c8c to
77eaea3
Compare
StephenCWills
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some of the "isItem" functions add an unnecessary check of isEmpty which is redundant, because a few lines lower they also check for item type inside the same object.
This patch removes those unnecessary checks.