Displacement#distance: Use a naive hypot impl
#6761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
force-pushed
the
naive-magnitude
branch
from
f6ee12f to
afa5c56
Compare
`std::hypot` is much slower than a naive implementation. It has the advantage of extra precision but we don't need that at all.
glebm
force-pushed
the
naive-magnitude
branch
from
afa5c56 to
38e0506
Compare
AJenbo
approved these changes
Nov 2, 2023
|
Wonder if we should add an assert... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::hypotis much slower than a naive implementation. It has the advantage of extra precision but we don't need that at all.Conveniently, this also works around the nxdk issue. We can also cherry-pick this for 1.5.