Migrate from SimpleIni to our own implementation #7511
Conversation
glebm
force-pushed
the
ini
branch
3 times, most recently
from
a0c116b to
3bd9980
Compare
Our implementation has a more modern interface and only supports the features that we care about. It always outputs `\n` as newlines and does not output BOM. The modern interface eliminates awkward `c_str()/data()` conversions. This implementation preserves comments and the file order of sections and keys. New keys are written in insertion order. We now also support modifying and adding default comments, which may be a useful thing to do for the especially tricky ini options (this PR doesn't add any but adds the ability to do so). Sadly, this increases the RG99 binary size by 24 KiB. I'm guessing this is because the map implementation generates quite a bit of code. Note that while it might seem that using `std::string` for every key and value would do a lot of allocations, most of these strings are small and thus benefit from Small String Optimization (= no allocations).
Some platforms do not have the C++20 `string_view(begin, end)` constructor.
Appears to be unimplemented on several platforms
Considering INI files are a Windows thing and we extend diablo.ini maybe it should be |
|
I never was particularly happy with any of the ini libs. I like the cleaner options code, was this the main reason for the change? |
SimpleIni produced Note that INI libraries on Windows support
Yeah, I wanted to clean that up a bit and figured writing an INI library from scratch won't be that difficult. |
|
I like consistency, I think we should go for the Windows endings since it's often accessed my non technical users and it's what it's been for most users and we don't know how diablo reacts if it's files was changed to the other format. |
|
Done, switched to |
Our implementation has a more modern interface and only supports the features that we care about.
It always outputs
\r\nas newlines and does not output BOM.The modern interface eliminates awkward
c_str()/data()conversions.This implementation preserves comments and the file order of sections and keys. New keys are written in insertion order.
We now also support modifying and adding default comments, which may be a useful thing to do for the especially tricky ini options (this PR doesn't add any but adds the ability to do so).
Sadly, this increases the RG99 binary size by 24 KiB. I'm guessing this is because the map implementation generates quite a bit of code.
Note that while it might seem that using
std::stringfor every key and value would do a lot of allocations, most of these strings are small and thus benefit from Small String Optimization (= no allocations).