Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Amiga build configs #7518

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Update Amiga build configs #7518

merged 1 commit into from
Nov 10, 2024

Conversation

glebm
Copy link
Collaborator

@glebm glebm commented Nov 10, 2024 •
edited
Loading

  1. Updates the Dockerfile to the same image and flags as the CI.
  2. Sets -O2 as the default CMake Release flag rather than passing it in a custom way.

This fixes building by following the instructions in building.md.

/cc @arczi84

@glebm
Update Amiga build configs
9f3b7f7 
1. Updates the Dockerfile to the same image and flags as the CI.
2. Sets `-O2` as the default CMake Release flag rather than passing it
   in a custom way.
@glebm glebm enabled auto-merge (rebase) November 10, 2024 00:24
AJenbo
AJenbo approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@AJenbo AJenbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this resolves the issue there where currently with the builds, but not telling it to do both o3 and o2 probably isn't a bad idea :D

@glebm glebm merged commit 44d5d2d into diasurgical:master Nov 10, 2024
23 checks passed
@glebm glebm deleted the amiga-updates branch November 10, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJenbo AJenbo AJenbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glebm @AJenbo