Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua: Add i18n module #7636

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Lua: Add i18n module #7636

merged 1 commit into from
Jan 11, 2025

Conversation

glebm
Copy link
Collaborator

@glebm glebm commented Jan 10, 2025

Adds bindings for i18n functions.
Does not yet add support for loading mod-specific translations.

Screenshot from 2025-01-10 15-15-05

Adds bindings for i18n functions.
Does not yet add support for loading mod-specific translations.
@glebm glebm enabled auto-merge (rebase) January 10, 2025 15:17
@glebm glebm merged commit 736a69c into diasurgical:master Jan 11, 2025
23 checks passed
@AJenbo
Copy link
Member

AJenbo commented Jan 11, 2025

i suppose the clock mod could se this to pick a format based on current lag, or maybe its better to wait till we can load translations and have that way instead ... though i prefer english with 24h

@glebm glebm deleted the lua-i18n branch January 11, 2025 11:46
@glebm
Copy link
Collaborator Author

glebm commented Jan 11, 2025

In the future, the format should probably be a setting of the clock mod because our locales are mostly not region-specific.

E.g. "en-US" is "1:00 PM" while "en-GB" is "13:00" but our locale is just "en".

@AJenbo
Copy link
Member

AJenbo commented Jan 11, 2025

we do support both i think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants