Merge limitFPS and vSync options #7646
Merged
+33
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJenbo
force-pushed
the
fps
branch
2 times, most recently
from
68131d8 to
fecb7c2
Compare
glebm
reviewed
Jan 12, 2025
glebm
approved these changes
Jan 12, 2025
Co-authored-by: Gleb Mazovetskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7170
This merges vSync and limitFPS under a new settings that uses an enum, and hides the option from Android users.
The reason not to carry over the setting from previous version is that Android users might have set a bad combination, both were on by default and they changed vsync to off they would likely experience the mentioned crash. So to fix any potentially bad settings we reset it to the new default of vsync only.