Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added configure conan #20

Merged
merged 8 commits into from
Jun 3, 2024
Merged

added configure conan #20

merged 8 commits into from
Jun 3, 2024

Conversation

mcb5637
Copy link
Contributor

@mcb5637 mcb5637 commented May 31, 2024

No description provided.

Copy link
Contributor

@liss-h liss-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the actions in seperate directories?

@mcb5637
Copy link
Contributor Author

mcb5637 commented Jun 3, 2024

Because it needs to be called action.yml, otherwise GitHub complains that it can not find it.
See https://github.com/dice-group/dice-sparse-map/actions/runs/9317805578/job/25648861616

@liss-h
Copy link
Contributor

liss-h commented Jun 3, 2024

Because it needs to be called action.yml, otherwise GitHub complains that it can not find it. See https://github.com/dice-group/dice-sparse-map/actions/runs/9317805578/job/25648861616

I think thats because they need to be in the workflows directory, no idea why but on every other action we have here it works that way

@mcb5637
Copy link
Contributor Author

mcb5637 commented Jun 3, 2024

These are actions, just single steps in a workflow.
If they are in the workflow folder, that gives a different error.

@mcb5637 mcb5637 marked this pull request as ready for review June 3, 2024 14:57
@mcb5637 mcb5637 requested a review from liss-h June 3, 2024 14:57
@liss-h liss-h merged commit 90fdbfd into develop Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants