Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request; added User Shops and AAA #21

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

themeels
Copy link

@themeels themeels commented Aug 9, 2023

Added User Shops and Almost Abandoned Attic. Created README file for guidance on using in the Attic as it’s not perfect due to the differences in the way that shop functions.

Updated Dice’s Search Helper to include:
User Shops
Almost Abandoned Attic (see README)
Adds search icons under items in various areas.
Almost Abandoned Attic is tricky because the image and text are linked to each other in the No Haggle option. To use the Search Helper icons in the Attic, hit "Cancel" and the link will open.

![image](https://github.com/themeels/NeoSearchHelper/assets/64810580/3a554a86-1dd7-47df-bf68-6aee02ee1984)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to be adding a readme image to this, the image should be hosted as an asset in the git repository directly, or as a public image like on imgur.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure how one would add it as an hosted asset to the git repository, would it just need to be added by Dice?

searchhelper.user.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants